chore(*): update changelog #12383
chore(*): update changelog #12383
Conversation
| $secondary-color: #f96a88; | ||
| $surface-color: #e1ebe4; | ||
| // Additional colors | ||
| $error-color: color($light-fluent-palette, 'error'); |
There was a problem hiding this comment.
I wonder if it's possible to migrate this type of calls:
$app-palette: palette($primary: $primary, $secondary: $secondary, $grays: $grays);
@include dark-theme(
$palette: $app-palette,
$exclude: map-keys(map-remove($components, $include...),)
);to this:
$app-palette: palette($primary: $primary,
$secondary: $secondary,
$grays: $grays,
// auto-migrated to material dark based on dark-theme preset call
$error: color($dark-material-palette, 'error'),
$warn: color($dark-material-palette, 'warn'),
$info: color($dark-material-palette, 'info'),
$success: color($dark-material-palette, 'success')
);
@include dark-theme(
$palette: $app-palette,
$exclude: map-keys(map-remove($components, $include...),)
);There was a problem hiding this comment.
Just to mention that the same thing happened with the greys in one of the previous updates and wasn't auto-migrated, so we have to think about how to handle these cases automatically.
There was a problem hiding this comment.
@SisIvanova I'm not sure if you should answer this question. Your PR is ready for merge, but since there's a hanging discussion here, I would like to get an answer prior to merging it, so it doesn't get lost.
There was a problem hiding this comment.
@kdinev Yes, we are planning to provide fallback values for these colors and it should be done soon.
There was a problem hiding this comment.
@SisIvanova So, if there's going to be a default fallback, then a migration would not be needed, I guess?
There was a problem hiding this comment.
@kdinev Yes, no migration is needed.
kdinev
added
📖 documentation
✅ status: verified
Related to IgniteUI/igniteui-theming/issues/55
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)