Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate css custom properties #12409

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Conversation

wnvko
Copy link
Contributor

@wnvko wnvko commented Dec 2, 2022

Migrate all custom CSS properties (aka CSS variables) prefix from --igx- to --ig-. Also migrates if CSS custom property contains grays migrate it to gray, e.g. --igx-grays-200 will be migrated to --ig-gray-200.

Closes #12389

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@Lipata Lipata changed the base branch from master to 15.0.x December 2, 2022 09:58
@wnvko wnvko force-pushed the mvenkov/migrate-css-custom-properties branch from fc77657 to 638b948 Compare December 2, 2022 11:26
@wnvko wnvko changed the title test(migrations): test for --igx to --ig and grays to gray migration Migrate css custom properties Dec 2, 2022
@jackofdiamond5 jackofdiamond5 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 2, 2022
@Lipata Lipata merged commit 4225982 into 15.0.x Dec 3, 2022
@Lipata Lipata deleted the mvenkov/migrate-css-custom-properties branch December 3, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrations version: 15.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sass variables are not migrated with upgrade to 15.0.0
4 participants