-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow entering edit mode if PrimaryKey is not set - 14.2 #12423
Conversation
This PR partially changes current grid behavior in the following way: Current behavior for grid with enabled editing, no New behavior @sdimchevski @dkamburov Are you OK with this change? |
@hanastasov @georgianastasov @sdimchevski Also do we really need this for both editing modes? Isn't cell editing working without primary key? And the bigger concern If we go with this fix. We previously didn't stop users from entering edit mode and now we do, sounds like a breaking change. Should be included in the changelog and drop fixes for 14.2. And maybe there were some scenarios were this isn't required, but now it will be. |
@hanastasov @dkamburov @sdimchevski On the other hand, when the The given changes are related to this issue #12393 in order not to enter row edit mode without editing overlay and without displaying the following error Cannot read properties of undefined (reading 'getBoundingClientRect'), but only to display a warning. This also relates perhaps to breaking change as @dkamburov mentioned. |
@hanastasov @georgianastasov @dkamburov I'm OK with a warning in the console. That's where all the devs are looking anyway so. |
Closes #12393
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)