Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow entering edit mode if PrimaryKey is not set - 15.0 #12425

Merged
merged 8 commits into from
Dec 12, 2022

Conversation

georgianastasov
Copy link
Contributor

Closes #12393

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@georgianastasov georgianastasov added the ❌ status: awaiting-test PRs awaiting manual verification label Dec 6, 2022
@georgianastasov georgianastasov changed the title Don't allow entering edit mode if PrimaryKey is not set Don't allow entering edit mode if PrimaryKey is not set - 15.0 Dec 6, 2022
@teodosiah teodosiah requested a review from hanastasov December 7, 2022 11:02
@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 7, 2022
@hanastasov hanastasov merged commit ff0e9c2 into 15.0.x Dec 12, 2022
@hanastasov hanastasov deleted the ganastasov/fix-12393-15.0 branch December 12, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: row-editing grid version: 15.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants