Fix demos type checks and warnings, some cleanup #12460
Merged
+63
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdinev
reviewed
Dec 14, 2022
| @@ -25,11 +25,6 @@ <h3>Grid with primary key ProductID</h3> | |||
| <igx-column field="ReorderLevel" width="200px" [sortable]="true" [filterable]="true" [editable]="true" [dataType]="'number'" [hasSummary]="false"> | |||
| </igx-column> | |||
| <igx-column field="ProductName" width="200px" [groupable]="kk" [header]="pname" [sortable]="true" [dataType]="'string'" [editable]="true" [resizable]="true"> | |||
| <ng-template igxCellValidationError let-cell='cell'> | |||
There was a problem hiding this comment.
Isn't this needed in the sample?
There was a problem hiding this comment.
Nope, this is checking for the custom forbiddenName error, which is only set up in the validation sample. Also was using formGroup prop which doesn't exist -> type error.
kdinev
previously approved these changes
Dec 15, 2022
|
@damyanpetev I've changed the target branch to |
kdinev
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
ng serve --configuration productionnow buildsAdditional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)