Skip to content

npm(igniteui-theming): move from peer to production deps #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

simeonoff
Copy link
Collaborator

Closes #12461

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@simeonoff simeonoff added 🧱 ci: build CI build related issues and PRs npm version: 15.0.x labels Dec 15, 2022
@simeonoff simeonoff requested a review from kdinev December 15, 2022 12:32
@@ -12,6 +12,7 @@
"igniteui-trial-watermark",
"lodash-es",
"uuid",
"@igniteui/material-icons-extended"
"@igniteui/material-icons-extended",
"igniteui-theming"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ng-package.prod.json used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault 🤦‍♂️ Going too fast for my own good.

@kdinev kdinev merged commit 4b87bc7 into 15.0.x Dec 15, 2022
@kdinev kdinev deleted the simeonoff/theming-deps branch December 15, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱 ci: build CI build related issues and PRs npm version: 15.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants