Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser integration test #616

Merged
merged 41 commits into from May 10, 2019
Merged

Add browser integration test #616

merged 41 commits into from May 10, 2019

Conversation

Macil
Copy link
Member

@Macil Macil commented May 10, 2019

Box: Implement an SDK Integration Test

@Macil
Copy link
Member Author

Macil commented May 10, 2019

The old code from the Inbox test I reused here found an error with the InboxSDK in Gmail: it seems like certain MessageViews aren't being emitted by the InboxSDK to registerMessageViewHandler callbacks, but are visible in ThreadView's getMessageViews() method. For now I commented out the part of the test that failed because of this. I'm going to fix that issue separately from this.

@Macil Macil merged commit ac5698b into master May 10, 2019
@Macil Macil deleted the test branch May 10, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant