-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
791 #1575
Open
myapos
wants to merge
12
commits into
Infisical:main
Choose a base branch
from
myapos:791
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
791 #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add multiple projects from organization level
…ng a key with useState, removed redundant comments, clean up, splitted code in separate files
… checkboxes component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
#791
Type ✨
This PR allows to give a user access to multiple projects at once. In order to do this I modified the organization access control page to fetch for each user the projects that already belongs to and added an action that will display a modal. The modal contains a table with all the available projects that a user can be added. The table also contains a search box and checkboxes to allow multiple selection of the users. I applied client side validation in order to avoid to send empty requests to the backend.
In the backend side, I added a new API call that will fetch all organization members with the projects that a user already belongs. Please let me know if this API call has to be added to the swagger too.
Further improvements could be
Tests 🛠️
empty_file_structure_fix-2024-03-15_19.17.44.mp4