-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret replication #1775
base: main
Are you sure you want to change the base?
Secret replication #1775
Conversation
fb759c0
to
c671253
Compare
178eb03
to
59044e7
Compare
backend/src/services/secret-replication/secret-replication-dal.ts
Outdated
Show resolved
Hide resolved
backend/src/services/secret-replication/secret-replication-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/secret-replication/secret-replication-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/secret-replication/secret-replication-service.ts
Outdated
Show resolved
Hide resolved
frontend/src/views/SecretMainPage/components/SecretImportListView/SecretImportItem.tsx
Outdated
Show resolved
Hide resolved
Order doesn't matter for replicated secret @sheensantoscapadngan |
… and replication dal
2167b76
to
9952aec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about adding a warning modal that pops up when they try to edit a replicated secret?
frontend/src/views/SecretMainPage/components/SecretImportListView/SecretImportItem.tsx
Show resolved
Hide resolved
frontend/src/views/SecretMainPage/components/SecretImportListView/SecretImportListView.tsx
Show resolved
Hide resolved
The replicated secret is treated as normal to an extend. Only difference is if gets replicated when source changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments in slack
Description 📣
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets