feat: delimiter flag for export command #1822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nettijoe96 custom formatting outisde of the predefined ones can be achieved with templates https://infisical.com/docs/cli/commands/export#infisical-export:template. I believe you can achieve what you added for this PR with templates. Let me know if you think otherwise. |
|
Agreed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Creates new flags
delimitandquotafor theexportcommand.delimitis currently only for CSV format.quotais only for .env formats. There are 2 flags rather than 1 because default handling is clearer and it allows for the possibility to extend delimit flag to .env for changing=in the future. Flags are permissive -- if format is not CSV or .env and a flag is provided, the flag is ignored and the command doesn't failResolves: #1103
Type ✨
Tests 🛠️
See unit tests in
cli/cmd_test.goManually: