Skip to content

Commit

Permalink
Merge pull request #1867 from InsertKoinIO/checkmodules_deprecate
Browse files Browse the repository at this point in the history
Checkmodules deprecation
  • Loading branch information
arnaudgiuliani committed May 3, 2024
2 parents 624545a + 3378cbc commit 450f7fe
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 12 deletions.
10 changes: 5 additions & 5 deletions examples/gradle/versions.gradle
Expand Up @@ -2,15 +2,15 @@ ext {
// Kotlin
kotlin_version = '1.9.23'
// Koin Versions
koin_version = '3.6.0-Beta2'
koin_version = '3.6.0-Beta4'
koin_android_version = koin_version
koin_compose_version = "1.2.0-Beta2"
koin_compose_version = "1.2.0-Beta4"

coroutines_version = "1.8.0"
ktor_version = "2.3.9"
ktor_version = "2.3.10"
// Compose
compose_compiler = "1.5.11"
jb_compose_version = "1.6.1"
jb_compose_version = "1.6.2"

// Test
junit_version = "4.13.2"
Expand All @@ -22,5 +22,5 @@ ext {
android_min_version = 14
android_target_version = 34
android_build_tools_version = '33.0.1'
android_gradle_version = '7.4.1'
android_gradle_version = '7.4.2'
}
Expand Up @@ -40,6 +40,7 @@ import org.koin.test.parameter.MockParameter
/**
* Check all definition's dependencies - start all modules and check if definitions can run
*/
@Deprecated("Migrate to verify() API")
fun KoinApplication.checkModules(parameters: CheckParameters? = null) = koin.checkModules(parameters)

/**
Expand All @@ -49,6 +50,7 @@ fun KoinApplication.checkModules(parameters: CheckParameters? = null) = koin.che
* @param parameters - parameter setup
* @param appDeclaration - koin Application
*/
@Deprecated("Migrate to verify() API")
fun checkModules(level: Level = Level.INFO, parameters: CheckParameters? = null, appDeclaration: KoinAppDeclaration) {
startKoin(appDeclaration)
.logger(KoinPlatformTools.defaultLogger(level))
Expand All @@ -62,6 +64,7 @@ fun checkModules(level: Level = Level.INFO, parameters: CheckParameters? = null,
* @param appDeclaration - Koin app config if needed
* @param parameters - Check parameters DSL
*/
@Deprecated("Migrate to verify() API")
fun checkKoinModules(modules: List<Module>, appDeclaration: KoinAppDeclaration = {}, parameters: CheckParameters? = null) {
startKoin(appDeclaration)
.modules(modules)
Expand Down Expand Up @@ -98,6 +101,7 @@ fun checkKoinModules(vararg modules: Module, level: Level = Level.INFO, paramete
/**
* Check all definition's dependencies - start all modules and check if definitions can run
*/
@Deprecated("Migrate to verify() API")
fun Koin.checkModules(parametersDefinition: CheckParameters? = null) {
logger.info("[Check] checking modules ...")

Expand Down
Expand Up @@ -26,8 +26,10 @@ import kotlin.reflect.KClass

//TODO TO BE DEPRECATED in 3.6

@Deprecated("Migrate to verify() API")
data class CheckedComponent(val qualifier: Qualifier? = null, val type: KClass<*>)

@Deprecated("Migrate to verify() API")
class ParametersBinding(val koin: Koin) {

val parametersCreators = mutableMapOf<CheckedComponent, ParametersCreator>()
Expand Down
4 changes: 2 additions & 2 deletions projects/gradle.properties
Expand Up @@ -8,8 +8,8 @@ org.gradle.parallel=true
kotlin.code.style=official

#Koin
koinVersion=3.6.0-Beta3
koinComposeVersion=1.2.0-Beta3
koinVersion=3.6.0-Beta4
koinComposeVersion=1.2.0-Beta4

#Compose
jetpackComposeCompiler=1.5.11
Expand Down
10 changes: 5 additions & 5 deletions projects/gradle/libs.versions.toml
Expand Up @@ -11,16 +11,16 @@ dokka = "1.9.10"
# Android
agp = "7.4.2"
android-appcompat = "1.6.1"
android-activity = "1.8.2"
android-fragment = "1.6.2"
android-activity = "1.9.0"
android-fragment = "1.7.0"
androidx-viewmodel = "2.7.0"
androidx-commonJava8 = "2.7.0"
androidx-workmanager = "2.9.0"
androidx-navigation = "2.7.7"
# Compose
# /!\ Compose compiler in gradle.properties /!\
composeJB = "1.6.1"
composeJetpackRuntime = "1.6.5"
composeJB = "1.6.2"
composeJetpackRuntime = "1.6.7"
composeJetpackViewmodel = "2.7.0"
# Test
stately = "2.0.6"
Expand All @@ -29,7 +29,7 @@ jupiter = "5.9.3"
mockito = "4.7.0"
mockk = "1.13.2"
# Ktor
ktor = "2.3.9"
ktor = "2.3.10"
slf4j = "1.7.36"

[libraries]
Expand Down

0 comments on commit 450f7fe

Please sign in to comment.