Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: suppress 5 clang warnings from eigen headers #4670

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

seanm
Copy link
Contributor

@seanm seanm commented May 15, 2024

These 4 warnings occur nowhere else in the ITK codebase, so suppressing them here allows them to be enabled on CI.

@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:ThirdParty Issues affecting the ThirdParty module labels May 15, 2024
@thewtex thewtex requested a review from phcerdan May 16, 2024 15:07
@thewtex
Copy link
Member

thewtex commented May 16, 2024

\azp run ITK.Linux

@dzenanz
Copy link
Member

dzenanz commented May 16, 2024

/azp run ITK.Linux

These 5 warnings occur nowhere else in the ITK codebase, so suppressing them here allows them to be enabled on CI.
@seanm seanm changed the title COMP: suppress 4 clang warnings from eigen headers COMP: suppress 5 clang warnings from eigen headers May 16, 2024
@seanm
Copy link
Contributor Author

seanm commented May 16, 2024

Added a 5th suppression here for -Wzero-as-null-pointer-constant.

@thewtex thewtex merged commit 8e5abbd into master May 20, 2024
16 checks passed
@thewtex thewtex deleted the eigen-warnings branch May 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Compiler Compiler support or related warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants