Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix output path for WriteImage test #4678

Merged
merged 1 commit into from
May 31, 2024
Merged

BUG: fix output path for WriteImage test #4678

merged 1 commit into from
May 31, 2024

Conversation

blowekamp
Copy link
Member

Addresses creation of test1.mha file in wrong place.

Fix the variable name and the preprocessor stringification.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp
BUG: fix output path for WriteImage test
4bd4065 
Addresses creation of test1.mha file in wrong place.

Fix the variable name and the preprocessor stringification.
@blowekamp blowekamp requested a review from dzenanz May 17, 2024 18:30
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:IO Issues affecting the IO module labels May 17, 2024
dzenanz
dzenanz approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What used to be the content of ITK_TEST_OUTPUT_DIR_STR?

@blowekamp
Copy link
Member Author

What used to be the content of ITK_TEST_OUTPUT_DIR_STR?

It appeared to be undefined and no change directory operation occoured.

@blowekamp
Copy link
Member Author

It seems that when the test is run through ctest the path is automatically changed to the correct TEST_DIR. However when the GTest driver is directly called it is now. The latter may be more consistent with the behavior of the other itk custom test drivers, so this extra change dir may not really be needed.

@hjmjohnson hjmjohnson merged commit d0b4eae into InsightSoftwareConsortium:master May 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:IO Issues affecting the IO module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blowekamp @thewtex @hjmjohnson @dzenanz