COMP: Fix -Wextra-semi Warnings for Macro #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to see if the following changes regarding the -Wextra-semi (semi = semicolon) warning of clang can be done throughout the repository. This is for a macro that is not function-like. It should not contain a semicolon. It is a method that is declared and defined in a header so no semi colon is needed. Are these following changes accepted to proceed with the other cases in the repository?
github-actions
bot
added
type:Compiler
|
This is just a first example of removing the semi-colon for a non-function-like macro (as opposed to a function-like macro). If there are no objections to this pattern, we'll apply it for other such macros. |
|
👍 looks good, thanks! |
thewtex
approved these changes
May 22, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to see if the following changes regarding the -Wextra-semi (semi = semicolon) warning of clang can be done throughout the repository.
This is for a macro that is not function-like. It should not contain a semicolon. It is a method that is declared and defined in a header so no semi colon is needed.
Are these following changes accepted to proceed with the other cases in the repository?