Drop Residence integration #2135
Open
+0
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tbh unless it becomes a work-required feature, there's no need to remove residence support. If wherever we're pulling it in as a dependency has a compatible version with the latest residence releases then it's all good imo |
|
About which Residence we talk? I found a fork on spigot that seemed active https://github.com/Zrips/Residence |
|
The issue is not how active it is, it's that it's to using any sort of build tooling, has no maven repository provided, etc. I suggest only removing residence at such a time the current integration no longer works, unless residence decides to become a useable open source project |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2081:
Residence uses a non-standardized approach to build and distribute binaries, incompatible with the industry standard.
There have been community efforts on Residence's end to maven-ize the project, see
https://github.com/Zrips/Residence/issues/42. Given there's been no progress in the past 6 years, I see no reason why we should continue maintaining our integration relying on our artifact, if the maintainer shows lack of motivation to move the community effort forward.As shown by telemetry data, the impact of removal is surveyable. To be fair, I wouldn't take the 2% affected as gospel truth because our integration works if Fawe and Residence are both installed, which does not imply that everyone using Fawe and Residence alongside necessarily use Fawe's Residence features.
Nevertheless, I'll add an entry to the upcoming changelog to communicate this change and the reasoning.