Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folia 1.19.4-1.20.2 support #2309

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

Folia 1.19.4-1.20.2 support #2309

wants to merge 81 commits into from
+1,123 −170

Conversation

TheMeinerLP
Copy link
Contributor

@TheMeinerLP TheMeinerLP commented Jun 18, 2023 •
edited

Overview

Very Caution this PR is very unstable and had some bugs. Feel free to report it

Description

Thats a very unstable support for folia 1.20.1
I mad a own task board: https://themeinerlp.notion.site/Fawe-1-20-1-Update-6ccace890c2242c58da5a141db31ca21?pvs=4
Checkout this here for current issue status

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner June 18, 2023 15:53
@TheMeinerLP TheMeinerLP marked this pull request as draft June 18, 2023 15:53
@github-actions github-actions bot added the Feature This PR adds a new feature label Jun 18, 2023
@TheMeinerLP TheMeinerLP mentioned this pull request Jun 18, 2023
Closed
5 tasks
@Munchy-cheater
Copy link

Munchy-cheater commented Jun 20, 2023 •
edited

//wand runs into a deadlock in this version (same behavior as the issue detailed on your website)
//thru seems to cause a similar issue, but haven't confirmed yet if it is the same deadlock issue

deadlock

@Yomamaeatstoes
Copy link

I have confirmed that if you use //want the whole server crashes.

@TheMeinerLP
Copy link
Contributor Author

I have confirmed that if you use //want the whole server crashes.

Thanks to to know. I am currently to busy with other private tasks

SirYwell and others added 23 commits September 19, 2023 10:56
@SirYwell @TheMeinerLP
Initial experimental work on Folia support
de92aee
@SirYwell @TheMeinerLP
Improve block tracing performance
1fc2f90
@SirYwell @TheMeinerLP
Throw exception if player is retired to ensure task always finishes
72b9a8b
@TheMeinerLP
Add folia support
c193f75
@TheMeinerLP
Add run folia task
d092e36
@TheMeinerLP
Port taskmanager for folia
40affbe
@TheMeinerLP
Fix tasks manager
668d5f5
@TheMeinerLP
Fix port for folia
49f038e
@TheMeinerLP
Build back to paper adapter
d6ce47f
@TheMeinerLP
Add special adapter load for folia
38661e3
@TheMeinerLP
Add folia adapter
723f720
@TheMeinerLP
Fix package for classes
9f3e114
@TheMeinerLP
Fix package for classes
6ddba75
@TheMeinerLP
Improve search for folia adapter
af92230
@TheMeinerLP
Fix shading of folia adapters
7030213
@TheMeinerLP
Add runFolia with snapshot version of run paper
5a8814d
@TheMeinerLP
Fix regen command
22d9a48
@TheMeinerLP
Fix UnsupportedOperationException on disable
677651f
@TheMeinerLP
Use new method to check of is running on "main thread"
c0e1388
@TheMeinerLP
Implement dirty workaround for get data from right ticking region
9d06640
@TheMeinerLP
Implement dirty workaround for get data from right ticking region
2b46e19
@TheMeinerLP
Implement dirty workaround for get data from right ticking region
67333d1
@TheMeinerLP
Improve scheduling for chunk data of regen
9a3f3e7
@TheMeinerLP
Fix compass tool
c841222
@TheMeinerLP
Fix duplicated import
efc43b5
@TheMeinerLP
Add folia check
535b26b
@TheMeinerLP
Implements method handles for folia
3e88790
@TheMeinerLP
Implements method handles for folia
e89e5c1
@TheMeinerLP
Implements method handles for folia
f066939
@TheMeinerLP
Add folia workaround
296baf0
@TheMeinerLP
Fix reflections and casting
e1ca178
@TheMeinerLP
Fix access to world data
fcfdc03
@TheMeinerLP
Remove folia search path
903a697
@TheMeinerLP
Remove duplicated code
ffd9159
@TheMeinerLP
Add multi folia run task support
dc77ce9
@TheMeinerLP
Add comment out folia dependency
9875ad7
@TheMeinerLP
Add sync at method for chunks
4818f37
@TheMeinerLP
Implement folia support
d7bdaf0
@TheMeinerLP
Merge remote-tracking branch 'origin/feature/folia/1-20-update' into …
dea40d1 
…feature/folia/1-20-update

# Conflicts:
#	build.gradle.kts
#	worldedit-bukkit/adapters/adapter-1_20/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_20_R1/PaperweightFaweAdapter.java
@TheMeinerLP TheMeinerLP changed the title Folia 1.20.1 support Folia 1.19.4-1.20.2 support Dec 3, 2023
This was referenced Dec 3, 2023
Closed
Closed
@Vadim998082
Copy link

can confirm that 1.20.2 fawe build with this PR causes deadlock while using //wand

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

@nyancat-hu
Copy link

/jumpto command will cause MSTP 1000+

@masmc05
Copy link

masmc05 commented Dec 27, 2023

error spam https://mclo.gs/51AumlV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature This PR adds a new feature unresolved-merge-conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@TheMeinerLP @Munchy-cheater @Yomamaeatstoes @SlayorPlayz @Vadim998082 @nyancat-hu @masmc05 @SirYwell