Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the entity remover and increase readability #2571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheMeinerLP
Copy link
Contributor

Overview

This pr improves the readability of the entity remover and removes some potential memory issue

Description

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner February 4, 2024 15:16
@github-actions github-actions bot added the Feature This PR adds a new feature label Feb 4, 2024
@dordsor21
Copy link
Member

PR would be better suited for upstream tbh

@TheMeinerLP
Copy link
Contributor Author

@dordsor21 I know that, but last time I was put down a bit to improve code. Since then I've had an aversion to them.
But feel free to copy the idea and pitch it to them. Please understand my decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants