Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rollback database query #2591

Merged
merged 1 commit into from Mar 2, 2024
Merged

fix rollback database query #2591

merged 1 commit into from Mar 2, 2024

Conversation

SirYwell
Copy link
Member

Overview

Fixes #2555

Description

ascending being false caused the query to contain a player = ? case, however, this results in an empty result if we don't pass any uuid.

By cleaning up how we build the query, we can simplify the code and fix the issue.

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@SirYwell SirYwell requested a review from a team as a code owner February 26, 2024 17:53
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Feb 26, 2024
@NotMyFault NotMyFault requested a review from a team March 2, 2024 11:02
@NotMyFault NotMyFault merged commit f5dfe3a into main Mar 2, 2024
9 checks passed
@NotMyFault NotMyFault deleted the fix/inspect-rollback branch March 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

//inspect does not show who performed the worldedit operation
3 participants