Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to process all chunks in PQE even if PARALLEL_THREADS = 1 #2611

Merged
merged 1 commit into from Mar 15, 2024

Conversation

SirYwell
Copy link
Member

Overview

Description

While current use of PQE in FAWE is always covered by a check to ensure PARALLEL_THREADS is > 1, a more defensive strategy might make sense. Alternatively to this change, we could assert that PT > 1, but that seems unnecessary.

Tested by manually setting PARALLEL_THREADS to 1 via debugger directly before the Math.min call.

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@SirYwell SirYwell requested a review from a team as a code owner March 10, 2024 17:43
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 10, 2024
@NotMyFault NotMyFault requested a review from a team March 10, 2024 17:44
@NotMyFault NotMyFault merged commit 10dc64e into main Mar 15, 2024
9 checks passed
@NotMyFault NotMyFault deleted the fix/potential-pqe-issue branch March 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants