fix: do not forcefully direct to x,y,z methods in AbstractDelegateExtent #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we probably shouldn't be doing this
dordsor21
force-pushed
the
fix/delegate-extent-coord-bv3
branch
from
23b35f4
to
521d26d
Compare
|
How does this affect extending extents? E.g. SlowExtent only overrides the method that takes ints, and I assume that might also apply for other extents. |
|
Input/Output extent have default methods that just redirect to the other method. This change just means we're not creating new BV3 objects if the delegate extent only overrides the BV3 method(s) - it shouldn't have any other impacts. |
NotMyFault
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably shouldn't be doing this