Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: apply final/abstract to various fawe extent classes #2615

Merged
merged 2 commits into from Mar 16, 2024
Merged

refactor: apply final/abstract to various fawe extent classes #2615

merged 2 commits into from Mar 16, 2024

Conversation

dordsor21
Copy link
Member

No description provided.

@dordsor21 dordsor21 requested a review from a team as a code owner March 11, 2024 15:03
@dordsor21
Copy link
Member Author

Thoughts?

@github-actions github-actions bot added the chore label Mar 11, 2024
@SirYwell
Copy link
Member

That's breaking in theory, would it make sense to target v3 instead?

@dordsor21
Copy link
Member Author

Ah yeah had meant to do that

@dordsor21 dordsor21 changed the base branch from main to v3 March 11, 2024 17:23
@dordsor21
Copy link
Member Author

I'll fix this lol

@dordsor21 dordsor21 marked this pull request as draft March 11, 2024 17:23
@dordsor21 dordsor21 force-pushed the refactor/make-extents-final-and-abstract branch from 7add936 to acda71b Compare March 15, 2024 10:25
@dordsor21 dordsor21 marked this pull request as ready for review March 15, 2024 10:57
@SirYwell
Copy link
Member

You removed the comment from BlockTransformExtent but you didn't make it final, I assume that was unintentional?

@dordsor21
Copy link
Member Author

You removed the comment from BlockTransformExtent but you didn't make it final, I assume that was unintentional?

Yeah I realised it was a WE class

NotMyFault
NotMyFault approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally

@NotMyFault NotMyFault merged commit fb12ff2 into v3 Mar 16, 2024
9 checks passed
@NotMyFault NotMyFault deleted the refactor/make-extents-final-and-abstract branch March 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dordsor21 @SirYwell @NotMyFault