New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly (de)serialise ItemType #2620

Merged

NotMyFault merged 1 commit into main from fix/item-type-json-deserialisation

Mar 15, 2024

Member

dordsor21 commented Mar 15, 2024 •

edited

InternalId changes depending on {magic} so we should not store this value
fixes Cherry Sign acting as Navigation Wand #2589


          fix: correctly (de)serialise ItemType

650b974

 - InternalId changes depending on ~~magic~~ so we should not store this value
 - fixes #2589

dordsor21 requested a review from a team as a code owner

March 15, 2024 10:45

github-actions bot added the Bugfix label

SirYwell approved these changes

View reviewed changes

NotMyFault approved these changes

View reviewed changes

NotMyFault merged commit 8363bad into main

9 checks passed

NotMyFault deleted the fix/item-type-json-deserialisation branch

March 15, 2024 17:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment