Allow repeated keys in RandomCollection #2624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
Noise-based patterns can benefit from allowing the same pattern multiple times, e.g.
#simplex[10][red_wool,blue_wool,red_wool,green_wool]
maps random values from[0, 1)
to[red_wool, blue_wool, red_wool, green_wool]
([0, 0.25)
->red_wool
and[0.5, 0.75)
->red_wool
), while before,red_wool
was just added up to have a weight of 2.Additionally, we move the random instance out of the collection. The collection doesn't actually depend on a (stateful) random, so that's a bit cleaner.
Submitter Checklist
@since TODO
.