Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow repeated keys in RandomCollection #2624

Merged
merged 1 commit into from Mar 16, 2024

Conversation

SirYwell
Copy link
Member

Overview

Description

Noise-based patterns can benefit from allowing the same pattern multiple times, e.g. #simplex[10][red_wool,blue_wool,red_wool,green_wool] maps random values from [0, 1) to [red_wool, blue_wool, red_wool, green_wool] ([0, 0.25) -> red_wool and [0.5, 0.75) -> red_wool), while before, red_wool was just added up to have a weight of 2.

Additionally, we move the random instance out of the collection. The collection doesn't actually depend on a (stateful) random, so that's a bit cleaner.

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@SirYwell SirYwell requested a review from a team as a code owner March 16, 2024 11:27
@github-actions github-actions bot added the Feature This PR adds a new feature label Mar 16, 2024
@NotMyFault NotMyFault merged commit 472eb19 into v3 Mar 16, 2024
7 checks passed
@NotMyFault NotMyFault deleted the feature/v3/improve-random-collections branch March 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants