Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not error when attempting to parse "|" as a pattern #2625

Merged
merged 1 commit into from Mar 17, 2024
Merged

fix: do not error when attempting to parse "|" as a pattern #2625

merged 1 commit into from Mar 17, 2024

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 requested a review from a team as a code owner March 16, 2024 12:47
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 16, 2024
@Zeranny
Copy link
Contributor

Zeranny commented Mar 16, 2024

My fix was gonna be to copy the check from WE for if (blockAndExtraData.length == 0), but I think this is a nicer method.

I've tested your fix and it looks to have fixed the error :)

@NotMyFault NotMyFault requested a review from a team March 16, 2024 19:13
@NotMyFault NotMyFault merged commit 2d0a3e6 into main Mar 17, 2024
9 checks passed
@NotMyFault NotMyFault deleted the fix/vert-bar-start-pattern-parse branch March 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beside Mask Shorthand Parsing Error
4 participants
@dordsor21 @Zeranny @SirYwell @NotMyFault