Fix Linear pattern index incrementing above array length

[Zeranny]

Overview

When running async the #linear pattern can increment index above the length of the patternsArray.
This tends not to happen on small operations.

[14:49:33 ERROR]: [com.fastasyncworldedit.core.queue.implementation.ParallelQueueExtent] Catching
java.lang.ArrayIndexOutOfBoundsException: Index 9 out of bounds for length 3
        at com.fastasyncworldedit.core.function.pattern.LinearBlockPattern.apply(LinearBlockPattern.java:37) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.function.pattern.Pattern.applyBlock(Pattern.java:59) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.filter.LinkedFilter.applyBlock(LinkedFilter.java:28) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.filter.block.CharFilterBlock.filter(CharFilterBlock.java:130) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.regions.Region.filter(Region.java:367) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.regions.Region.filter(Region.java:301) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.regions.CuboidRegion.filter(CuboidRegion.java:762) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.filter.block.ChunkFilterBlock.filter(ChunkFilterBlock.java:88) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.queue.implementation.chunk.ChunkHolder.filterBlocks(ChunkHolder.java:903) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.queue.IQueueExtent.apply(IQueueExtent.java:144) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.queue.implementation.ParallelQueueExtent.lambda$apply$0(ParallelQueueExtent.java:162) ~[FastAsyncWorldEdit-Bukkit-2.9.1-SNAPSHOT.jar:?]
        at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(Unknown Source) ~[?:?]
        at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) ~[?:?]
        at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source) ~[?:?]
        at java.util.concurrent.ForkJoinPool.scan(Unknown Source) ~[?:?]
        at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) ~[?:?]
        at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) ~[?:?]

Replication steps for error:

1. Select a decently large selection (64^3 seems enough)
2. Set a linear pattern such as //set #linear[1,2,3]
3. Chat ingame may report a success but the operation will either fully or partially fail with OoB errors in console as above

Description

Changes the index calculation to always modulo with the patternsArray length to prevent an Out of Bounds exception.

While this fixes the error, the linear pattern itself is quite messy when running async:

I'm not sure if it's worth changing anything, as if you were to make it ordered then it would just look like the #linear3d pattern.

Submitter Checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter Checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.

   Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry.

   Ensure that the pull request title represents the desired changelog entry.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. New public fields and methods are annotated with `@since TODO`.

   New public fields and methods are annotated with @since TODO.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

   I read and followed the contribution guidelines.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter Checklist

[dordsor21]

We can use the Filter#fork method to correctly handle async pattern access

[Zeranny]

I added the fork method (copy pasta from #2633)

The resulting pattern is more ordered, but it's still odd. I'm kinda questioning what purpose #linear serves

[SirYwell]

It's behavior fully depends on iteration order, but yeah, I'm not sure if it's actually useful in any scenario.

[dordsor21]

On none-parallel operations like fill, sphere (I think?) etc. it'd work?

I would also say close this in favour of #2633 as that addresses the issue in the rest of the patterns too

[Zeranny]

On none-parallel operations like fill, sphere (I think?) etc. it'd work?

I would also say close this in favour of #2633 as that addresses the issue in the rest of the patterns too

It looks different with spheres, but still doesn't seem to useful:

I would agree the thread safe part can be covered by #2633, however if I remove the overflow safety and just have fork, I can still get the out of bounds error, so that portion of this PR is still relevant.