Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linear patterns using RandomPattern + SimpleRandom #2630

Merged
merged 1 commit into from Mar 17, 2024

Conversation

SirYwell
Copy link
Member

Overview

Description

Instead of having specific implementations for #linear2d and #linear3d, we can implement them using RandomPattern and specific SimpleRandom implementations.

This has the benefit that weighted patters aren't just ignored but allow for more interesting results.
Example: #linear2d[white_wool,2%light_gray_wool,4%gray_wool,8%black_wool]

l2d

Submitter Checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter Checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
    Options
  2. Ensure that the pull request title represents the desired changelog entry.
    Options
  3. New public fields and methods are annotated with @since TODO.
    Options
  4. I read and followed the contribution guidelines.
    Options

@SirYwell SirYwell requested a review from a team as a code owner March 17, 2024 08:41
@github-actions github-actions bot added the Feature This PR adds a new feature label Mar 17, 2024
@dordsor21 dordsor21 requested a review from a team March 17, 2024 09:16
@NotMyFault NotMyFault merged commit dc61efe into main Mar 17, 2024
9 checks passed
@NotMyFault NotMyFault deleted the feature/LinearRandom branch March 17, 2024 12:17
@NotMyFault
Copy link
Member

This has the benefit that weighted patters aren't just ignored but allow for more interesting results.
Example: #linear2d[white_wool,2%light_gray_wool,4%gray_wool,8%black_wool]

Would be nice to have this documented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants