Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queryRel returning data value for block at absolute coordinates #2645

Merged
merged 2 commits into from Mar 23, 2024
Merged

Fix queryRel returning data value for block at absolute coordinates #2645

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
380abb5
Replace toWorld with toWorldRel for relative data
Zeranny Mar 22, 2024
5b181ab
re-add accidentally deleted annotation
Zeranny Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...-core/src/main/java/com/sk89q/worldedit/regions/shape/WorldEditExpressionEnvironment.java
View file
Open in desktop
Expand Up @@ -83,9 +83,8 @@ public int getBlockTypeRel(double x, double y, double z) {
}

@SuppressWarnings("deprecation")
@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annotation should be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, didn't mean to remove that

public int getBlockDataRel(double x, double y, double z) {
return extent.getBlock(toWorld(x, y, z)).getBlockType().getLegacyCombinedId() & 0xF;
return extent.getBlock(toWorldRel(x, y, z).toBlockPoint()).getBlockType().getLegacyCombinedId() & 0xF;
}

//FAWE start
Expand Down