Support for 1.20.5/6

[SirYwell]

Overview

Description

Submitter Checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter Checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.

   Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry.

   Ensure that the pull request title represents the desired changelog entry.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. New public fields and methods are annotated with `@since TODO`.

   New public fields and methods are annotated with @since TODO.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

   I read and followed the contribution guidelines.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter Checklist

[scarfacered]

I receive this error when running //wand

[Craft Scheduler Thread - 3 - FastAsyncWorldEdit/ERROR]: An unexpected error while handling a FastAsyncWorldEdit command
java.lang.IllegalStateException: Not a map: null
	at com.mojang.serialization.DataResult$Error.getOrThrow(DataResult.java:275) ~[datafixerupper-7.0.14.jar:?]
	at com.mojang.serialization.DataResult.getOrThrow(DataResult.java:79) ~[datafixerupper-7.0.14.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R4.PaperweightFaweAdapter.adapt(PaperweightFaweAdapter.java:501) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.bukkit.BukkitAdapter.adapt(BukkitAdapter.java:495) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.bukkit.BukkitPlayer.giveItem(BukkitPlayer.java:163) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.extension.platform.PlayerProxy.giveItem(PlayerProxy.java:84) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.command.SelectionCommands.wand(SelectionCommands.java:337) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.command.SelectionCommandsRegistration.cmd$_wand(SelectionCommandsRegistration.java:409) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/org.enginehub.piston.CommandManager.execute(CommandManager.java:157) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.extension.platform.PlatformCommandManager.lambda$handleCommandOnCurrentThread$16(PlatformCommandManager.java:725) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.extension.platform.PlatformCommandManager.handleCommandTask(PlatformCommandManager.java:746) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.extension.platform.PlatformCommandManager.handleCommandOnCurrentThread(PlatformCommandManager.java:727) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar/com.sk89q.worldedit.extension.platform.PlatformCommandManager.lambda$handleCommand$13(PlatformCommandManager.java:690) ~[FastAsyncWorldEdit-Bukkit-2.9.3-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.6.jar:git-Paper-"447f9a1"]
	at org.bukkit.craftbukkit.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.20.6.jar:git-Paper-"447f9a1"]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.20.6.jar:?]
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[rwnd-bradley]

Fails to build with ./gradlew clean build:

FastAsyncWorldEdit\worldedit-bukkit\src\main\java\com\sk89q\bukkit\util\CommandRegistration.java:103: error: constructor SimpleCommandMap in class SimpleCommandMap cannot be applied to given types;
            fallbackCommands = commandMap = new SimpleCommandMap(Bukkit.getServer());
                                            ^
  required: Server,Map<String,Command>
  found:    Server
  reason: actual and formal argument lists differ in length

However, the actions built jar is working well from my testing 😄

[SirYwell]

Seems like Paper broke API compatibility with PaperMC/Paper#8235

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[NotMyFault]

Is this ready to be merged?

[SirYwell]

I think so