Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bees leaving their beehives with disabled natural_mob_spawning #3997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ByteExceptionM
Copy link
Contributor

Overview

Bees that are in nests will not be able to get out of them, because the event will be canceled if the configuration natural_mob_spawning is disabled. No new entities will be spawned - the entity already exists, but is only in the beehive. To work around this you would have to enable natural_mob_spawning so far, but this results e.g. in entities being spawned as well when generating chunks. I think the best solution is to remove the check for beehives here to make this possible again.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

Signed-off-by: ByteExceptionM <git@byteexception.eu>
@ByteExceptionM ByteExceptionM requested a review from a team as a code owner March 20, 2023 09:32
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Mar 20, 2023
@NotMyFault
Copy link
Member

It's not that easy afaik, this introduces regressions.

@github-actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants