New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent loading faraway chunks #4370

Merged

NotMyFault merged 2 commits into main from fix/out-of-range-positions

Mar 7, 2024

Member

SirYwell commented Mar 7, 2024

Overview

Fixes #4340

Description

This adds some safety checks before attempting to load faraway chunks that can cause the server to crash.

Submitter Checklist

Beta Give feedback

Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.

Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry.

Ensure that the pull request title represents the desired changelog entry.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public fields and methods are annotated with `@since TODO`.

New public fields and methods are annotated with @since TODO.
Options
Successfully updated the issue's project

There was an error updating the issue's project
I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

I read and followed the contribution guidelines.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

SirYwell added 2 commits

March 7, 2024 18:34


          Prevent loading faraway chunks

b51eec2


          docs

6e668cd

SirYwell requested a review from a team as a code owner

March 7, 2024 17:38

github-actions bot added the Bugfix label

NotMyFault approved these changes

View reviewed changes

NotMyFault requested a review from a team

March 7, 2024 19:02

PierreSchwang approved these changes

View reviewed changes

Member

PierreSchwang left a comment

Untested, but looks reasonable

NotMyFault merged commit 2321831 into main

8 checks passed

NotMyFault deleted the fix/out-of-range-positions branch

March 7, 2024 20:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment