Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tullia tasks and cicero action for CI #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dermetfan
Copy link

@dermetfan dermetfan commented Oct 17, 2022

Also purified nix evaluation of hydra jobs.

@dermetfan dermetfan force-pushed the tullia branch 2 times, most recently from 9ce0c1a to 4063368 Compare October 18, 2022 20:12
@dermetfan dermetfan requested a review from jbgi October 18, 2022 20:18
@dermetfan dermetfan marked this pull request as ready for review October 19, 2022 08:19
@dermetfan dermetfan force-pushed the tullia branch 2 times, most recently from 2e65d1a to 1dbe5ce Compare October 19, 2022 11:56
@piotr-iohk
Copy link
Contributor

There is this cicero job failing https://cicero.ci.iog.io/run/940d28a9-711e-408b-8ccb-7f7388ccf7bb, I guess this needs to be addressed before merging @dermetfan?

@dermetfan
Copy link
Author

@piotr-iohk I think no. It fails because the nix build is failing, which is what CI is supposed to report, so CI is working.

@piotr-iohk
Copy link
Contributor

@paweljakubas @HeinrichApfelmus do you know why is this job failing and how to fix it? https://cicero.ci.iog.io/run/940d28a9-711e-408b-8ccb-7f7388ccf7bb

@HeinrichApfelmus
Copy link
Contributor

do you know why is this job failing and how to fix it?

Unfortunately, I am unable to tell from the Cicero UI whether the job is failing or not. I see the following items:

  • "General information" > "Status | succeeded"
  • "Facts" > "55ef357e-84d5-40f1-b94c-bd9c87e8e06c" > { "ok": true, …}
  • "Task groups" > "nomad" > "General information" > "Failed | false"
  • "Task groups" > "nomad" > "General information" > "State | dead"
  • "Task groups" > "nomad" > "Task log" > second-to last line: error: builder for '/nix/store/yxnam041qfml8hc0q1ziygn9hgjkaqad-cardano-addresses-demo-js-3.12.0.drv' failed with exit code 1

How do I make heads or tails of this?

@dermetfan
Copy link
Author

@HeinrichApfelmus

"General information" > "Status | succeeded"
"Facts" > "55ef357e-84d5-40f1-b94c-bd9c87e8e06c" > { "ok": true, …}
"Task groups" > "nomad" > "General information" > "Failed | false"

Unfortunately this status is often wrong (since we switched to the podman driver iirc). We are aware of this and there's an open issue.

Truth is that nix build .#hydraJobs.x86_64-linux.packages.x86_64-linux.cardano-addresses-demo-js failed:

Building .#hydraJobs.x86_64-linux.packages.x86_64-linux.cardano-addresses-demo-js…
 drv: /nix/store/yxnam041qfml8hc0q1ziygn9hgjkaqad-cardano-addresses-demo-js-3.12.0.drv
 out: /nix/store/p36paw07gwwc4nz0kafy4pvwh2brvpnx-cardano-addresses-demo-js-3.12.0
...
cardano-addresses-demo-js> dist directory is missing - you need to 'npm run build' first
error: builder for '/nix/store/yxnam041qfml8hc0q1ziygn9hgjkaqad-cardano-addresses-demo-js-3.12.0.drv' failed with exit code 1

@HeinrichApfelmus
Copy link
Contributor

Unfortunately this status is often wrong (since we switched to the podman driver iirc). We are aware of this and there's an open issue.

@dermetfan thanks. While we're at it: Could you also change the status description "Failed: false" to "Success: true"? Reading the double negative is very confusing.

@HeinrichApfelmus
Copy link
Contributor

do you know why is this job failing and how to fix it?

@piotr-iohk I have no idea. Apparently, the nix expression for cardano-addresses-demo-js fails to build. There seems to be something wrong with the JavaScript parts, npm complains that you need to 'npm run build' first.

@dermetfan dermetfan force-pushed the tullia branch 6 times, most recently from a2ab6bd to 4130508 Compare October 21, 2022 15:58
@dermetfan dermetfan marked this pull request as draft November 21, 2022 13:19
@dermetfan dermetfan marked this pull request as ready for review November 22, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants