-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 3187 #3198
Merged
ILIYANGERMANOV
merged 10 commits into
Ivy-Apps:main
from
luispacheco-dev:fix-issue-3187
May 16, 2024
Merged
Fix issue 3187 #3198
ILIYANGERMANOV
merged 10 commits into
Ivy-Apps:main
from
luispacheco-dev:fix-issue-3187
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a few comments that needs to be addressed
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
ILIYANGERMANOV
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
main
branch.Screen_recording_20240514_202544.mov
What's changed?
Sort income and expenses categories in alphabetical order. The option is added in Features screen (Screen is disabled by default).
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.