Add KtLint baseline support #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapchicoma
force-pushed
the
414/add-baseline-support
branch
2 times, most recently
from
5087f80
to
c06996c
Compare
Tapchicoma
force-pushed
the
414/add-baseline-support
branch
from
eb73d0b
to
7460a90
Compare
Tapchicoma
force-pushed
the
414/add-baseline-support
branch
2 times, most recently
from
4286245
to
ed71f90
Compare
JLLeitschuh
requested changes
May 25, 2021
plugin/src/main/kotlin/org/jlleitschuh/gradle/ktlint/tasks/GenerateBaselineTask.kt
Show resolved
Hide resolved
| */ | ||
| val baseline: RegularFileProperty = objectFactory.fileProperty() | ||
| .convention( | ||
| projectLayout.projectDirectory.file("ktlintBaseline.xml") |
There was a problem hiding this comment.
Would it be better to make the convention having this inside of a directory instead of in the project directory?
There was a problem hiding this comment.
which directory do you have in mind? Something like $projectDir/ktlint/ktlintBaseline.xml?
There was a problem hiding this comment.
Have changed it to $projectDir/config/ktlint/baseline.xml
This task will generate project baseline file based on all found style issues.
Tapchicoma
force-pushed
the
414/add-baseline-support
branch
from
ed71f90
to
d206cf0
Compare
It is constantly failing on Github Windows Agent, while working locally on another windows installation. It is ok just to check it on Linux OS.
Tapchicoma
force-pushed
the
414/add-baseline-support
branch
from
aa03c10
to
edc6f92
Compare
JLLeitschuh
approved these changes
Jun 1, 2021
| @@ -14,6 +16,7 @@ class UnsupportedGradleTest : AbstractPluginTest() { | |||
| .withGradleVersion("5.6.4") | |||
|
|
|||
| @Test | |||
| @DisabledOnOs(OS.WINDOWS) | |||
There was a problem hiding this comment.
Gradle test daemon disappearing on Github Windows runner. I've tried to reproduce it on another windows installation, but test there is passing successfully.
And actually it is ok to run this test only on Linux runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial KtLint baseline support with following limitations:
Reporterinterface to generate baseline file. Theoretically it will be possible to introduce special generate task in the root project that will trigger all subprojects, collects all errors and then write one baseline file, but let us see how big demand for it will be.Fixes #414