Add --binary when creating patch for unstaged files
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamBorland
changed the title
--binary when creating patch for unstaged files
|
Sorry it's taken so long to get back to you on this. I'm happy to merge this, but I need an entry in the changelog file. After that, more than happy to merge this! |
|
Changelog entry added, thanks! |
|
Looks like CI is failing for this PR. Can you take a look? |
|
Once CI is passing, I'm more than happy to merge this 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the pre-commit hook to cope with unstaged binary files. Without this option, the hook fails when there is an unstaged binary file.