Merge pull request #684 from justjavac/master

field name can not by empty
JakeChampion · Jan 2, 2019 · 3674c98 · 3674c98
2 parents 1821b74 + 96b37eb
commit 3674c98
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/fetch.js b/fetch.js
@@ -44,7 +44,7 @@ function normalizeName(name) {
   if (typeof name !== 'string') {
     name = String(name)
   }
-  if (/[^a-z0-9\-#$%&'*+.^_`|~]/i.test(name)) {
+  if (/[^a-z0-9\-#$%&'*+.^_`|~]/i.test(name) || name === '') {
     throw new TypeError('Invalid character in header field name')
   }
   return name.toLowerCase()

diff --git a/test/test.js b/test/test.js
@@ -262,6 +262,9 @@ exercise.forEach(function(exerciseMode) {
           var headers = new Headers()
           headers.set({field: 'value'}, 'application/json')
         }, TypeError)
+        assert.throws(function() {
+          new Headers({'': 'application/json'})
+        }, TypeError)
       })
       featureDependent(test, !brokenFF, 'is iterable with forEach', function() {
         var headers = new Headers()