fix: ignore not throw on invalid response headers

Fixes #930
JakeChampion · Apr 1, 2023 · e74fa5b · e74fa5b
1 parent a43b628
commit e74fa5b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/fetch.js b/fetch.js
@@ -437,7 +437,11 @@ function parseHeaders(rawHeaders) {
       var key = parts.shift().trim()
       if (key) {
         var value = parts.join(':').trim()
-        headers.append(key, value)
+        try {
+          headers.append(key, value)
+        } catch (error) {
+          console.warn('Response ' + error.message)
+        }
       }
     })
   return headers

diff --git a/test/server.js b/test/server.js
@@ -120,6 +120,14 @@ const routes = {
       'Content-Type': 'text/html; charset=utf-8'
     })
     res.end()
+  },
+  '/invalid-headers': function(res) {
+    res.writeHead(200, {
+      'Content-Type': 'text/plain',
+      'Invalid Header': 'valid value',
+      'Westworld-S01': "<3"
+    })
+    res.end()
   }
 }
 

diff --git a/test/test.js b/test/test.js
@@ -1281,6 +1281,12 @@ exercise.forEach(function(exerciseMode) {
             assert.equal(response.headers.get('Content-Type'), 'text/html; charset=utf-8')
           })
         })
+        test('parses invalid headers', function() {
+          return fetch('/invalid-headers').then(function(response) {
+            assert.equal(response.headers.get('Content-Type'), 'text/plain')
+            assert.equal(response.headers.get('Westworld-S01'), '<3')
+          })
+        })
       })
 
       // https://fetch.spec.whatwg.org/#methods