Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browserify support #1

Closed
wants to merge 1 commit into from
Closed

Add browserify support #1

wants to merge 1 commit into from

Conversation

axross
Copy link

@axross axross commented Oct 14, 2014

Please support use on browserify.

@andrepadez
Copy link

this would be highly appreciated

@matthew-andrews
Copy link
Contributor

I don't think this is the right way to do this. It already works well in Browserify...

As this is a polyfill it's the one case where you probably would expect that it add itself to global scope.

This is working for me:-

require('fetch');

window.fetch('http://my-lovely-api.com/something.json')
  .then(function(res) { return res.json(); })
  .then(function(res) {
    console.log(res.data);
  });

[Note I'm using debowerify and installing this module via bower]

@andrepadez
Copy link

well, i agree then.

@axross
Copy link
Author

axross commented Oct 14, 2014

Well, that makes sense.

@axross axross closed this Oct 14, 2014
@matthew-andrews matthew-andrews mentioned this pull request Oct 15, 2014
@axross axross deleted the feature-browserify_support branch October 16, 2014 02:12
@axross axross restored the feature-browserify_support branch October 16, 2014 02:12
othree pushed a commit to othree/simple-fetch-ie8 that referenced this pull request Feb 19, 2016
fixed blob charset for different encoding
othree pushed a commit to othree/simple-fetch-ie8 that referenced this pull request Feb 19, 2016
dysonpro pushed a commit to dysonpro/fetch that referenced this pull request Feb 27, 2018
Clear abort event listener for all xhr completion states.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants