Change Headers multiple value handling for spec compatibility #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider this Headers object:
var h = new Headers()
h.append('accept', 'text/html')
h.append('accept', 'text/plain')
h.append('content-type', 'application/json')
Before:
- `h.get('accept')` returned `text/html`
- `h.getAll('accept')` returned an array of values
- `h.forEach` (and other iterables) did distinct iterations for each
value of the same header
Now:
- `h.get('accept')` returns `text/html,text/plain`
- `h.getAll()` is no more
- `h.forEach` (and other iterables) now only do one iteration for each
headers name, regardless of multiple values
This is in accordance with Section 3.1.2 of the spec, "combine" concept.
The updated tests currently break in Chrome and Firefox when exercising
the native implementation because their implementation is outdated. The
implementation in Edge is more correct, but the tests still fail there
because its implementation combines values with `, ` (notice the space)
rather than `,`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this Headers object:
Before:
h.get('accept')returnedtext/htmlh.getAll('accept')returned an array of valuesh.forEach(and other iterables) did distinct iterations for each value of the same headerNow:
h.get('accept')returnstext/html,text/plainh.getAll()is no moreh.forEach(and other iterables) now only do one iteration for each headers name, regardless of multiple valuesThis is in accordance with Section 3.1.2 of the spec, "combine" concept. whatwg/fetch@42464c8
The updated tests currently break in Chrome and Firefox when exercising the native implementation because their implementation is outdated. The implementation in Edge is more correct, but the tests still fail there because its implementation combines values with
,(notice the space) rather than,.