Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added safari to native fetch browser support. #469

Merged
merged 2 commits into from Mar 27, 2017

Conversation

RoneyThomas
Copy link
Contributor

@mislav
Copy link
Contributor

mislav commented Jan 25, 2017

Thanks! When is Safari 10.1 slated to ship?

@RoneyThomas
Copy link
Contributor Author

RoneyThomas commented Jan 25, 2017 via email

@@ -266,7 +266,7 @@ Firefox < 32, Chrome < 37, Safari, or IE.
- Safari 6.1+
- Internet Explorer 10+

Note: modern browsers such as Chrome, Firefox, and Microsoft Edge contain native
Note: modern browsers such as Chrome, Firefox, Microsoft Edge and Safari contain native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an Oxford comma.

@dgraham
Copy link
Contributor

dgraham commented Jan 25, 2017

I thought Fetch's presence in Safari Technology Preview implied it would be included with Safari 10 and added it to the list in a82b0a9. It didn't ship in version 10, so this was removed in c6c0a60. Maybe this time it will make it into the release!

@RoneyThomas
Copy link
Contributor Author

Sorry guys. I just checked macOS 10.12.3, Safari 10.1 hasn't been released. Sorry for the trouble.

@mislav
Copy link
Contributor

mislav commented Jan 25, 2017

We'll merge this when it ships. Thanks for the update!

@RoneyThomas
Copy link
Contributor Author

Safari 10.1 is out with MacOS 10.12.4. I have tried fetch and it works natively.

@dgraham dgraham merged commit fcf8476 into JakeChampion:master Mar 27, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants