Tweak the wording of the “Read this first” section #553
+15
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
suggested changes
Aug 3, 2017
README.md
Outdated
| application doesn't try to package and run this on the server. | ||
| * This project **doesn't work under Node.js environments**. It's meant for web | ||
| browsers only. You should ensure that your application doesn't try to package | ||
| and run this on the server. Try the [isomorphic-fetch][] package if you need |
There was a problem hiding this comment.
Could we not link to isomorphic-fetch? We tend to not officially endorse 3rd party projects unless we are familiar with them.
silverlyra
force-pushed
the
readme-tweaks
branch
from
0d19f9f
to
54dc3f8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the bullet on node.js particularly confusing. This breaks the parallel structure, but I think it's worth it. Made a few more edits while I was at it.