Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch test suite from PhantomJS to Karma #626

Merged
merged 22 commits into from May 25, 2018
Merged

Switch test suite from PhantomJS to Karma #626

merged 22 commits into from May 25, 2018

Commits on May 23, 2018

  1. Switch from PhantomJS to Karma + Chrome/Firefox for testing

    @mislav
    mislav committed May 23, 2018
    1 Configuration menu
    Copy the full SHA
    b539589 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Convert testing fetch under Web Workers to Karma

    @mislav
    mislav committed May 24, 2018
    91 Configuration menu
    Copy the full SHA
    4f09701 View commit details
    Browse the repository at this point in the history

  2. Nuke old testing setup

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    a55b7d7 View commit details
    Browse the repository at this point in the history

  3. Split header values with , to match other browsers 

    Chrome and Firefox both split `append`d values with `, `.
    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    fd151e9 View commit details
    Browse the repository at this point in the history

  4. Remove test that depends on specific abortcontroller-polyfill API 

    `signal.listeners` is not available in native implementations of AbortSignal.
    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    b7ea5f2 View commit details
    Browse the repository at this point in the history

  5. Load polyfills for testing older browsers

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    f75e24b View commit details
    Browse the repository at this point in the history

  6. Remove PhantomJS artifacts from tests

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    3f420d5 View commit details
    Browse the repository at this point in the history

  7. Only test native abortable functionality in browsers that implement it

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    837cac4 View commit details
    Browse the repository at this point in the history

  8. Fix abortable tests in Safari 

    Safari aggressively caches `/slow` endpoint after first load and serves
it up really fast on subsequent runs, not giving it enough time to
invoke `controller.abort()`.

Adding `Cache-Control` response headers from the server doesn't work.
Safari still serves `/slow` from disk cache, even though `/slow` was
never even allowed to finish on prior runs. My guess is that Safari
erroneously caches the result of `/slow` when the initial request was
aborted.
    @mislav
    mislav committed May 24, 2018
    1 Configuration menu
    Copy the full SHA
    711ab2f View commit details
    Browse the repository at this point in the history

  9. Skip testing functionality that doesn't seem implemented in IE/Edge

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    47d9084 View commit details
    Browse the repository at this point in the history

  10. Skip response.formData() test in native Safari/Edge 

    Just like in Chrome, this isn't supported natively.
    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    621b80d View commit details
    Browse the repository at this point in the history

  11. Add npm run karma for easier testing

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    48f70e2 View commit details
    Browse the repository at this point in the history

  12. Skip iterable tests broken in Firefox <= 56

    @mislav
    mislav committed May 24, 2018
    1 Configuration menu
    Copy the full SHA
    5826cfc View commit details
    Browse the repository at this point in the history

  13. Have test output in CI be less noisy

    @mislav
    mislav committed May 24, 2018
    Configuration menu
    Copy the full SHA
    36c5203 View commit details
    Browse the repository at this point in the history

  14. Configure eslint for node

    @mislav
    mislav committed May 24, 2018
    1 Configuration menu
    Copy the full SHA
    8be5431 View commit details
    Browse the repository at this point in the history

  15. Improve CONTRIBUTING documentation

    @mislav
    mislav committed May 24, 2018
    1 Configuration menu
    Copy the full SHA
    4a1e106 View commit details
    Browse the repository at this point in the history

  16. Tweak bullet styles

    @mislav
    mislav committed May 24, 2018
    1 Configuration menu
    Copy the full SHA
    8827a22 View commit details
    Browse the repository at this point in the history

  17. Enable AbortController polyfill in web worker mode 

    This should help Firefox 56 in CI which doesn't have AbortController.
    @mislav
    mislav committed May 24, 2018
    2 Configuration menu
    Copy the full SHA
    418b8ee View commit details
    Browse the repository at this point in the history

Commits on May 25, 2018

  1. Remove xvfb since it's no longer necessary in CI 

    I was just cargo-culting it from other setups
    @mislav
    mislav committed May 25, 2018
    Configuration menu
    Copy the full SHA
    b2bc05b View commit details
    Browse the repository at this point in the history

  2. Rename prepublish step to prepare

    @mislav
    mislav committed May 25, 2018
    Configuration menu
    Copy the full SHA
    9f2854b View commit details
    Browse the repository at this point in the history

  3. Avoid Node 6 deprecation warnings re: Buffer 

    https://nodejs.org/api/buffer.html#buffer_buffer_from_buffer_alloc_and_buffer_allocunsafe
    @mislav
    mislav committed May 25, 2018
    1 Configuration menu
    Copy the full SHA
    0ee11fa View commit details
    Browse the repository at this point in the history

  4. Install newer Firefox in hopes to avoid intermittent CI failures 

    https://travis-ci.org/github/fetch/builds/383771737
https://travis-ci.org/github/fetch/builds/383770926
https://travis-ci.org/github/fetch/builds/383767274
https://travis-ci.org/github/fetch/builds/383767224
    @mislav
    mislav committed May 25, 2018
    Configuration menu
    Copy the full SHA
    b891c46 View commit details
    Browse the repository at this point in the history