Update Karma and detect available browsers when testing #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari 11.1.2, the default for `credentials` is still "omit".
This was only useful while debugging cache issues.
keithamus
reviewed
Sep 3, 2018
test/karma.config.js
Outdated
| preferHeadless: true, | ||
| usePhantomJS: false, | ||
| postDetection: availableBrowsers => | ||
| availableBrowsers.map(browser => (browser.startsWith('Chrom') ? `${browser}NoSandbox` : browser)) |
There was a problem hiding this comment.
is never mind I see it also catches Chrom intentional here?Chromium
keithamus
approved these changes
Sep 3, 2018
|
This change causes a bizarre CI failure: Which would suggest that the version of Chrome used was 62, not 68. This branch uses the same karma-chrome-launcher version as master, so I can't guess right now why would the result be different. |
It seems like it's outdated: https://travis-ci.org/github/fetch/builds/424048996
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.