Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

field name can not by empty #684

Merged
merged 1 commit into from Jan 2, 2019
Merged

field name can not by empty #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion fetch.js
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ function normalizeName(name) {
if (typeof name !== 'string') {
name = String(name)
}
if (/[^a-z0-9\-#$%&'*+.^_`|~]/i.test(name)) {
if (/[^a-z0-9\-#$%&'*+.^_`|~]/i.test(name) || name === '') {
throw new TypeError('Invalid character in header field name')
}
return name.toLowerCase()
Expand Down
3 changes: 3 additions & 0 deletions test/test.js
View file
Open in desktop
Expand Up @@ -262,6 +262,9 @@ exercise.forEach(function(exerciseMode) {
var headers = new Headers()
headers.set({field: 'value'}, 'application/json')
}, TypeError)
assert.throws(function() {
new Headers({'': 'application/json'})
}, TypeError)
})
featureDependent(test, !brokenFF, 'is iterable with forEach', function() {
var headers = new Headers()
Expand Down