Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Response.arrayBuffer() always resolve with a ArrayBuffer #816

Merged
merged 2 commits into from Jul 31, 2020
Merged

Make Response.arrayBuffer() always resolve with a ArrayBuffer #816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f84db9
Make Response.arrayBuffer() always resolve with a `ArrayBuffer`
JakeChampion Jul 31, 2020
70f593c
Update fetch.js
JakeChampion Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion fetch.js
View file
Open in desktop
Expand Up @@ -274,7 +274,17 @@ function Body() {

this.arrayBuffer = function() {
if (this._bodyArrayBuffer) {
return consumed(this) || Promise.resolve(this._bodyArrayBuffer)
consumed(this)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consumed returns either undefined or a rejected Promise.

The previous code returned the rejected Promise.
This changes the original behaviour.
Was that intended?

if (ArrayBuffer.isView(this._bodyArrayBuffer)) {
return Promise.resolve(
this._bodyArrayBuffer.buffer.slice(
this._bodyArrayBuffer.byteOffset,
this._bodyArrayBuffer.byteOffset + this._bodyArrayBuffer.byteLength
)
)
} else {
return Promise.resolve(this._bodyArrayBuffer)
}
} else {
return this.blob().then(readBlobAsArrayBuffer)
}
Expand Down