Support kotlin static references #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JakeWharton is there any chance to merge this at some point? |
|
@TimoPtr I guess the project is abandoned |
|
The project is stable |
|
@JakeWharton why no PR's merged anymore? |
|
It's not a priority for me, and nothing is broken. Everything is a feature request. |
|
@JakeWharton got it. What is your policy to add new feature PR's to the project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new version of Timber it was not possible to use static references in Kotlin, like described in this issue #445.
To fix that, Forest is not a companion object of Timber anymore, and I added all the static functions to the Timber's companion object.
I added a dumb test, that only tests the usage of a static reference, but only with Throwable. I was not sure about the strategy to adopt, here do we add a small test for each static function or make a big one just to ensure that everything is invokable as a static reference in Kotlin. If needed I can test all the methods in order to ensure that future versions do not break this kind of usage.
I updated AGP but I can rollback if needed.