Skip to content

Commit

Permalink
[ts] Upgrade to TypeScript 3.9.2 (expo#8280)
Browse files Browse the repository at this point in the history
* [ts] Upgrade to TypeScript 3.9.2

This upgrades TypeScript to 3.9.2 to keep us more up to date. It also supports `@ts-expect-error` for places where we want to get notified if a future TS version stops triggering type checker errors. https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/

It is also supposed to be faster but I don't have real numbers on this. CI might be a reasonable indicator.

Also updated ts-jest, since there was a bug that required clearing the Jest cache.

Updated the TS version in expo-module-scripts. Ran `expotools check-packages --no-uniformity-check ` to rebuild, test, and lint all files.

* [ts] Fix up files for TS 3.9

* [ts] Rebuild JS files with TS 3.9.2
  • Loading branch information
ide committed May 16, 2020
1 parent fce6527 commit 2ce3b40
Show file tree
Hide file tree
Showing 6 changed files with 392 additions and 385 deletions.
8 changes: 4 additions & 4 deletions build/AV.d.ts
Expand Up @@ -97,14 +97,14 @@ export interface Playback extends AV {
export declare const PlaybackMixin: {
playAsync(): Promise<AVPlaybackStatus>;
playFromPositionAsync(positionMillis: number, tolerances?: {
toleranceMillisBefore?: number | undefined;
toleranceMillisAfter?: number | undefined;
toleranceMillisBefore?: number;
toleranceMillisAfter?: number;
}): Promise<AVPlaybackStatus>;
pauseAsync(): Promise<AVPlaybackStatus>;
stopAsync(): Promise<AVPlaybackStatus>;
setPositionAsync(positionMillis: number, tolerances?: {
toleranceMillisBefore?: number | undefined;
toleranceMillisAfter?: number | undefined;
toleranceMillisBefore?: number;
toleranceMillisAfter?: number;
}): Promise<AVPlaybackStatus>;
setRateAsync(rate: number, shouldCorrectPitch?: boolean, pitchCorrectionQuality?: PitchCorrectionQuality): Promise<AVPlaybackStatus>;
setVolumeAsync(volume: number): Promise<AVPlaybackStatus>;
Expand Down
276 changes: 140 additions & 136 deletions build/Audio/Sound.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2ce3b40

Please sign in to comment.