Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize docker (or podman) path #4222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

themagiulio
Copy link

Currently LaTeX Workshop supports only docker and it expects to have it in PATH. This small PR addresses this problem by creating a new config docker.path allowing the user to customize the location of docker.

This config makes also possible to use podman, a drop-in replacement of docker as explained in #1130, by setting docker.path to podman.

My commits makes this to work only in GNU/Linux and macOS as I modified only the bash scripts. Modifying the powershell scripts would make this fix available to Windows users as well.

@James-Yu
Copy link
Owner

James-Yu commented Apr 4, 2024

Thank you for your contribution. I vote a yes to this PR.

My commits makes this to work only in GNU/Linux and macOS as I modified only the bash scripts.

This is the remaining concern. Generally, we'd like to avoid platform-specific configs. Any solution?

@themagiulio
Copy link
Author

Thank you for creating this great extension.

This is the remaining concern. Generally, we'd like to avoid platform-specific configs. Any solution?

We just need to edit the bat files to invoke the program specified by the env variable LATEXWORKSHOP_DOCKER_PATH instead of docker. I am not a Windows user and I have never tinkered with bat files. The change should be simple to apply, but I don't know the syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants