Require adminstrator in app.manifest #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces manual user role check with "requireAdministrator" in app.manifest
From user standpoint it makes obvious, that app requires administrator permissions (shield icon) and improves startup time a bit
From developer standpoint it makes a bit easier to debug app: VisualStudio automatically offers to restart IDE with administrator rights if not yet, Rider writes message to console, asking for elevated permissions
Was:
Now:
(have no idea why GitHub fails to detect identation fix properly, so moved it to separate commit)