Merge pull request #316 from imofix/fix-internal-phpstan-error

Fix internal phpstan error
Jan0707 · Mar 4, 2024 · d750af9 · d750af9
2 parents 37238ea + 0f145e1
commit d750af9
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 8 deletions.
diff --git a/phpstan-without-extension-baseline.neon b/phpstan-without-extension-baseline.neon
@@ -22,22 +22,22 @@ parameters:
 
 		-
 			message: "#^Call to an undefined method Prophecy\\\\Prophecy\\\\ObjectProphecy\\:\\:doubleTheNumber\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php
 
 		-
 			message: "#^Call to an undefined method Prophecy\\\\Prophecy\\\\ObjectProphecy\\:\\:getFoo\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php
 
 		-
 			message: "#^Call to an undefined method object\\:\\:doubleTheNumber\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php
 
 		-
 			message: "#^Call to an undefined method object\\:\\:getFoo\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php
 
 		-

diff --git a/src/Type/Prophet/ProphesizeDynamicReturnTypeExtension.php b/src/Type/Prophet/ProphesizeDynamicReturnTypeExtension.php
@@ -66,10 +66,6 @@ public function getTypeFromMethodCall(
 
         $className = $argumentType->getValue();
 
-        if (!$returnType instanceof Type\TypeWithClassName) {
-            throw new ShouldNotHappenException();
-        }
-
         if ('static' === $className) {
             return $returnType;
         }

diff --git a/test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php b/test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php
@@ -16,6 +16,7 @@
 use JanGregor\Prophecy\Test\StaticAnalysis\Src;
 use PHPUnit\Framework;
 use Prophecy\Argument;
+use Prophecy\Prophet;
 
 /**
  * @internal
@@ -83,6 +84,24 @@ public function testCreateProphecyInHelperMethod(): void
         self::assertEquals(5, $testDouble->doubleTheNumber(2));
     }
 
+    public function testCreateProphecyInline(): void
+    {
+        $prophecy = (new Prophet())->prophesize(Src\BaseModel::class);
+
+        $prophecy
+            ->getFoo()
+            ->willReturn('bar');
+
+        $prophecy
+            ->doubleTheNumber(Argument::is(2))
+            ->willReturn(5);
+
+        $testDouble = $prophecy->reveal();
+
+        self::assertEquals('bar', $testDouble->getFoo());
+        self::assertEquals(5, $testDouble->doubleTheNumber(2));
+    }
+
     private function createProphecy()
     {
         return $this->prophesize(Src\BaseModel::class);