Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This updates JUnit, TestContainers, Lombok, and Mockito together as it wasn't possible to only update TestContainers alone since it also depends on JUnit, see PR #2972. The same applies to Mockito. These changes were necessary to update Mockito to v4: Import of `org.mockito.Matchers` needed to be changed to `org.mockito.ArgumentMatchers`. `Matchers` was already only an alias for `ArgumentMatchers` before as described in the release notes: https://github.com/mockito/mockito/releases/tag/v4.0.0 `any()` is the replacement for `anyObject()`: mockito/mockito#1931 Calling `property()` on a mocked `StandardVertex` resulted in a `NullPointer` exception, but we can also simply use a `DetachedProperty` as all accesses to that property on the vertex are also already mocked. Signed-off-by: Florian Hockmann <fh@florian-hockmann.de>
- Loading branch information
1 parent
6573fbb
commit b44aa6f
Showing
4 changed files
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b44aa6f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
org.janusgraph.MgmtOlapJobBenchmark.runRemoveIndex
114.33446810452196
ms/op115.50350859175475
ms/op0.99
org.janusgraph.JanusGraphSpeedBenchmark.basicAddAndDelete
13091.376943637955
ms/op16300.184954180237
ms/op0.80
org.janusgraph.GraphCentricQueryBenchmark.getVertices
2257.1661992124054
ms/op2428.923466905251
ms/op0.93
org.janusgraph.MgmtOlapJobBenchmark.runReindex
359.40913797999997
ms/op417.5135216876923
ms/op0.86
org.janusgraph.JanusGraphSpeedBenchmark.basicCount
346.62158918858387
ms/op395.27303250862536
ms/op0.88
This comment was automatically generated by workflow using github-action-benchmark.